Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the dnf5 package manager #66

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Conversation

jsf9k
Copy link
Member

@jsf9k jsf9k commented Nov 8, 2024

🗣 Description

This pull request adds support for the dnf5 package manager.

💭 Motivation and context

We are adding support for Fedora 41 soon in cisagov/skeleton-ansible-role#207, and ansible identifies the package manager for that platform as dnf5, so we need to support it.

🧪 Testing

All automated tests pass. These changes are also tested as part of cisagov/skeleton-ansible-role#207.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

We are adding support for Fedora 41 soon in
cisagov/skeleton-ansible-role#207, and that release only supports
dnf5, so we need to support it.
@jsf9k jsf9k added the improvement This issue or pull request will add or improve functionality, maintainability, or ease of use label Nov 8, 2024
@jsf9k jsf9k self-assigned this Nov 8, 2024
@jsf9k jsf9k force-pushed the feature/add-support-for-dnf5 branch from 32bf087 to d3cab99 Compare November 8, 2024 20:28
jsf9k added a commit to cisagov/skeleton-ansible-role that referenced this pull request Nov 8, 2024
Note that this is being done for testing purposes, and this change can
be reverted once cisagov/ansible-role-upgrade#66 is merged.
@jsf9k jsf9k marked this pull request as ready for review November 9, 2024 02:57
@jsf9k jsf9k requested a review from a team November 9, 2024 02:57
jsf9k added a commit to cisagov/freeipa-server-packer that referenced this pull request Nov 12, 2024
This is being done for testing purposes and this change can be
reverted once cisagov/ansible-role-upgrade#66 is merged.
@jsf9k jsf9k merged commit c4c08d5 into develop Nov 13, 2024
105 checks passed
@jsf9k jsf9k deleted the feature/add-support-for-dnf5 branch November 13, 2024 13:56
jsf9k added a commit to cisagov/freeipa-server-packer that referenced this pull request Nov 13, 2024
jsf9k added a commit to cisagov/skeleton-ansible-role that referenced this pull request Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement This issue or pull request will add or improve functionality, maintainability, or ease of use
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants