Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatted Vuln Details Severity Level (CRASM-1054) #750

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

hawkishpolicy
Copy link
Collaborator

@hawkishpolicy hawkishpolicy commented Dec 31, 2024

  • Brought the formatting of irregular severity levels displayed inside of Vulnerability Details into line with the remainder of the app.

🗣 Description

  • Title case is now applied to all vuln severity levels.
  • Null, undefined, N/A, and empty strings are now formatted to 'N/A'.
  • Low, Medium, High, and Critical are now formatted to 'Low', 'Medium', 'High', and 'Critical' respectively.
  • All other values are formatted to 'Other'.

💭 Motivation and context

  • Ensures the formatting of irregular severity levels remains constant across the app.
  • Closes CRASM-1054

🧪 Testing

  • tested locally

📷 Screenshots (if appropriate)

Screenshot 2024-12-31 at 2 19 51 PM Screenshot 2024-12-31 at 2 20 09 PM

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

- Added logic to format irregular vuln severity levels.
- Title case is now applied to all vuln severity levels.
- Null, undefined, N/A, and empty strings are now formatted to 'N/A'.
- Low, Medium, High, and Critical are now formatted to 'Low', 'Medium', 'High', and 'Critical' respectively.
- All other values are formatted to 'Other'.
@hawkishpolicy hawkishpolicy self-assigned this Dec 31, 2024
@hawkishpolicy hawkishpolicy changed the title Formatted Vuln Severity Level Formatted Vuln Details Severity Level Dec 31, 2024
Copy link
Collaborator

@nickviola nickviola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nickviola nickviola self-requested a review January 2, 2025 18:20
@hawkishpolicy hawkishpolicy changed the title Formatted Vuln Details Severity Level Formatted Vuln Details Severity Level (CRASM-1054) Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants