Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove MS.SHAREPOINT.4.1v1 policy and references (baseline only) #1228

Conversation

ahuynhMITRE
Copy link
Collaborator

@ahuynhMITRE ahuynhMITRE commented Jul 24, 2024

🗣 Description

💭 Motivation and context

M365 option to enable and disable custom scripting for on personal sites (aka OneDrive) has been deprecated from the classic settings page within the SharePoint Admin Center. Since this capability has been removed the policy and implementation steps will also be removed from the SCBs to minimize confusion from users. Context of this change has also been added to the removedpolicies.md file.

🧪 Testing

N/A only documentation updated captured as a part of this PR and issue

Closes #1227
Connected to the investigation done on issue #1216
Connected to the rego changes found in issue #1229

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • PR targets the correct parent branch (e.g., main or release-name) for merge.
  • Changes are limited to a single goal - eschew scope creep!
  • Changes are sized such that they do not touch excessive number of files.
  • All future TODOs are captured in issues, which are referenced in code comments.
  • All relevant type-of-change labels added.
  • All relevant project fields are set.
  • All relevant repo and/or project documentation updated to reflect these changes.
  • All relevant functional tests passed.
  • All automated checks (e.g., linting, static analysis, unit/smoke tests) passed.

✅ Pre-merge checklist

  • PR passed smoke test check.

  • Feature branch has been rebased against changes from parent branch, as needed

    Use Rebase branch button below or use this reference to rebase from the command line.

  • Resolved all merge conflicts on branch

  • Notified merge coordinator that PR is ready for merge via comment mention

✅ Post-merge checklist

  • Feature branch deleted after merge to clean up repository.
  • Verified that all checks pass on parent branch (e.g., main or release-name) after merge.

@ahuynhMITRE ahuynhMITRE added the baseline-document Issues relating to the text in the baseline documents themselves label Jul 24, 2024
@ahuynhMITRE ahuynhMITRE added this to the Iceberg milestone Jul 24, 2024
@ahuynhMITRE ahuynhMITRE self-assigned this Jul 24, 2024
@schrolla schrolla changed the title Removing MS.SHAREPOINT.4.1v1 policy and references due to Microsoft's update to custom scriptoptions Remove MS.SHAREPOINT.4.1v1 policy and references Jul 24, 2024
Copy link
Collaborator

@schrolla schrolla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recommend some updates to the removal rationale to fix typos and consider including more detailed reason for removal.

PowerShell/ScubaGear/baselines/removedpolicies.md Outdated Show resolved Hide resolved
@tkol2022
Copy link
Collaborator

@mitchelbaker-cisa @gdasher Since we are removing a policy from the baseline, if you have any questions about this, please let Andrew know.

Copy link
Collaborator

@schrolla schrolla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates look good and a test run of ScubaGear still runs as expected and reports for SharePoint no longer show 4.1 and no warnings or errors are issued.

@ahuynhMITRE ahuynhMITRE changed the title Remove MS.SHAREPOINT.4.1v1 policy and references Remove MS.SHAREPOINT.4.1v1 policy and references (baseline only) Jul 31, 2024
@ahuynhMITRE
Copy link
Collaborator Author

closing as complete with the merge of PR #1244

@ahuynhMITRE ahuynhMITRE deleted the 1227-mssharepoint41v1-option-to-enable-and-disable-custom-scripting-for-on-personal-sites-aka-onedrive-has-been-deprecated-by-microsoft-and-will-be-removed-from-scbs branch August 29, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
baseline-document Issues relating to the text in the baseline documents themselves
Projects
None yet
3 participants