Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify zeek's logstash pipeline to drop event from logs name that con… #221

Closed
wants to merge 1 commit into from

Conversation

rsatrio
Copy link

@rsatrio rsatrio commented Oct 20, 2022

Zeek sometimes generate logs like conn.2020_01_16_14_00_00.log. It will makes a lot of mess because it will generate custom field also like [zeek][conn.2020_01_16_14_00_00][column10] and so on. The current logstash pipeline configuration has handled it for logs name like conn.2020-01-16-14-00-00.log.

🗣 Description

Adding the if condition in Zeek's logstash pipeline to drop log with name pattern like conn.2020_01_16_14_00_00.log.

💭 Motivation and context

Because right now if the log name pattern like "conn.2020_01_16_14_00_00.log" occured, it will messed up the field name in Opensearch

🧪 Testing

Build the logstash container locally without failed. And when it integrate with Zeek, the logs still ingest properly.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • I have read the CONTRIBUTING document.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Add a tag or create a release.

…tain date like conn.2020_01_16_14_00_00.log
@mmguero
Copy link
Collaborator

mmguero commented Oct 20, 2022

Thanks! It looks like at some point Zeek changed from using dashes underscores. I'm going to cherry-pick your change into my upstream development fork rather than merging it here directly, I'll reference this PR number for documentation.

mmguero added a commit to mmguero-dev/Malcolm that referenced this pull request Oct 20, 2022
…tain date like conn.2020_01_16_14_00_00.log

Thanks to @rsatrio, see cisagov#221.

Will be included in v6.4.1 release.
@mmguero
Copy link
Collaborator

mmguero commented Oct 20, 2022

Closing this pull request as I've pulled your change into my upstream development repo (see mmguero-dev/Malcolm@c8f7303). It should now handle _ (underscore), - (dash), : (colon) or `` (no character) as separators for the date.

@mmguero
Copy link
Collaborator

mmguero commented Oct 20, 2022

See idaholab#121

mmguero added a commit to idaholab/Malcolm that referenced this pull request Nov 3, 2022
…tain date like conn.2020_01_16_14_00_00.log

Thanks to @rsatrio, see cisagov#221.

Will be included in v6.4.1 release.
mmguero added a commit that referenced this pull request Nov 3, 2022
…tain date like conn.2020_01_16_14_00_00.log

Thanks to @rsatrio, see #221.

Will be included in v6.4.1 release.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants