Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests after password encryption #466

Merged
merged 50 commits into from
Oct 17, 2024

Conversation

cbaxley
Copy link
Collaborator

@cbaxley cbaxley commented Oct 10, 2024

🗣 Description

The tests need to use the new passwords and urls that the encryption changes added

🧪 Testing

Make sure the tests in the pipelines pass

✅ Pre-approval checklist

  • There is a gitIssue that this PR resolves
  • Git Issue that this PR solves has been selected in the Development section
  • The PR's base branch has been modified to be the proper branch.
  • Changes are limited to a single goal AND
    the title reflects this in a clear human readable format
  • Issue that this PR solves has been selected in the Development section
  • I have read and agree to LME's CONTRIBUTING.md document.
  • The PR adheres to LME's requirements in RELEASES.md
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated to reflect the changes in this PR.

✅ Pre-merge Checklist

  • All tests pass.
  • PR has been tested and the documentation for testing is above.
  • Squash and merge all commits into one PR level commit.

✅ Post-merge Checklist

  • Delete the branch to keep down number of branches.
  • The PR is labeled with feat for an added new feature, update for an update, OR fix for a fix.
  • The PR contains Resolves #<issue #> so that merging it closes out the corresponding issue. For example Resolves #132.

@cbaxley cbaxley changed the base branch from main to release-2.0.0 October 10, 2024 10:51
…com:cisagov/LME into cbaxley-fix-tests-after-password-encryption
- add section for LME introductory content
- disclaimer around small simple siem
- add Pre-Requisites page
- add Upgrading 1.4 -> 2.0 docs
- note on lme-frontend coming later
- remove references to lmed and make docs accurate to current
  installation process
- add TODOs for docs that still need updated
Copy link
Collaborator

@mreeve-snl mreeve-snl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mreeve-snl mreeve-snl merged commit 1733589 into release-2.0.0 Oct 17, 2024
4 checks passed
@mreeve-snl
Copy link
Collaborator

merging and closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants