Default to latest tag (#60)

Similar to Tart
cirruslabs · Nov 13, 2024 · c376d63 · c376d63
1 parent 5a5130e
commit c376d63
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/internal/name/remotename/remotename.go b/internal/name/remotename/remotename.go
@@ -43,8 +43,7 @@ func NewFromString(s string) (RemoteName, error) {
 		return RemoteName{}, fmt.Errorf("%w: remote name cannot have both a tag and a digest",
 			ErrFailedToParse)
 	case !isTagged && !isDigested:
-		return RemoteName{}, fmt.Errorf("%w: remote name should either have a tag or a digest",
-			ErrFailedToParse)
+		remoteName.Tag = "latest"
 	case isTagged:
 		remoteName.Tag = tagged.Tag()
 	case isDigested:

diff --git a/internal/name/remotename/remotename_test.go b/internal/name/remotename/remotename_test.go
@@ -50,9 +50,14 @@ func TestInvalidNoNamespace(t *testing.T) {
 	require.ErrorIs(t, err, remotename.ErrFailedToParse)
 }
 
-func TestInvalidNoTagOrDigest(t *testing.T) {
-	_, err := remotename.NewFromString("ghcr.io/what/ever")
-	require.ErrorIs(t, err, remotename.ErrFailedToParse)
+func TestDefaultToLatestTag(t *testing.T) {
+	parsedRemoteName, err := remotename.NewFromString("ghcr.io/what/ever")
+	require.NoError(t, err)
+	require.Equal(t, remotename.RemoteName{
+		Registry:  "ghcr.io",
+		Namespace: "what/ever",
+		Tag:       "latest",
+	}, parsedRemoteName)
 }
 
 func TestInvalidBothTagAndDigest(t *testing.T) {