Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce "tart fqn" command #735

Merged
merged 3 commits into from
Feb 19, 2024
Merged

Introduce "tart fqn" command #735

merged 3 commits into from
Feb 19, 2024

Conversation

edigaryev
Copy link
Collaborator

This allows the tart pull's callee to figure out a fully qualified OCI image name of the pulled image (even if it was already cached).

@edigaryev edigaryev requested a review from fkorotkov as a code owner February 19, 2024 20:22
Copy link
Contributor

@fkorotkov fkorotkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think of a separate tart fqn hidden (shouldDisplay equal to false) subcommand that we can run similar to tart ip? This can return this fully qualified name of a remote image in the local cache.

@@ -12,16 +12,13 @@ var defaultLogger: Logger = {
return InteractiveConsoleLogger()
}
}()
var jsonLogger: Logger = NopLogger()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why it's a NopLogger?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because we don't output JSON by default.

@edigaryev
Copy link
Collaborator Author

What do you think of a separate tart fqn hidden (shouldDisplay equal to false) subcommand that we can run similar to tart ip? This can return this fully qualified name of a remote image in the local cache.

See 50cdd95.

@edigaryev edigaryev requested a review from fkorotkov February 19, 2024 21:02
@edigaryev edigaryev changed the title tart pull: experimental --json-digest option Introduce "tart fqn" command Feb 19, 2024
@edigaryev edigaryev enabled auto-merge (squash) February 19, 2024 21:09
@edigaryev edigaryev merged commit 3f17884 into main Feb 19, 2024
6 checks passed
@edigaryev edigaryev deleted the tart-pull-json-digest branch February 19, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants