-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce "tart fqn" command #735
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think of a separate tart fqn
hidden (shouldDisplay
equal to false
) subcommand that we can run similar to tart ip
? This can return this fully qualified name of a remote image in the local cache.
Sources/tart/Logging/Logger.swift
Outdated
@@ -12,16 +12,13 @@ var defaultLogger: Logger = { | |||
return InteractiveConsoleLogger() | |||
} | |||
}() | |||
var jsonLogger: Logger = NopLogger() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why it's a NopLogger
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because we don't output JSON by default.
See 50cdd95. |
This allows the
tart pull
's callee to figure out a fully qualified OCI image name of the pulled image (even if it was already cached).