Skip to content
This repository has been archived by the owner on May 7, 2024. It is now read-only.

Allow PR_NUMBER to be set externally #76

Merged
merged 1 commit into from
May 10, 2021
Merged

Allow PR_NUMBER to be set externally #76

merged 1 commit into from
May 10, 2021

Conversation

pezholio
Copy link
Contributor

I've put together an action that rebases a number of PRs in one go, and we would find it useful to be able to specify the PR_NUMBER externally. I've also added some initial documentation.

@fkorotkov
Copy link
Member

Hey @pezholio, could you please elaborate on your use case? Why are you specifying the PR explicitly in the YAML and not just commenting on the corresponding PRs?

@pezholio
Copy link
Contributor Author

@fkorotkov So, in my case, if we have a lot of open PRs (such as from Dependabot, for example), there's a constant round of merging one PR, then rebasing the next PR, then merging, then rebasing. I've added an action that, on merge to master/develop, we cycle through all open PRs that are set to auto merge, then loop through them and rebase i.e.

https://github.com/UKGovernmentBEIS/beis-report-official-development-assistance/blob/75b46f8cc33ed73ac628793b13128aa4d3ac3dff/.github/workflows/trigger_rebase.yml

@fkorotkov
Copy link
Member

Oh! You are using output of one action to generate a matrix of actions for each PR to be rebased on. I see.

Seems a bit costly if you rebase all PRs for each PR. I think you can only rebase the oldest open PR ready to auto-merge to reduce the amount of rebase actions from n*(n-1)/2 to just n where n is the amount of PRs ready to auto-merge.

@fkorotkov fkorotkov merged commit 9d21e09 into cirrus-actions:master May 10, 2021
@pezholio
Copy link
Contributor Author

Cool, thanks for the merge and the tips! 👍

xzile pushed a commit to Interfolio/rebase that referenced this pull request Apr 19, 2022
xzile pushed a commit to Interfolio/rebase that referenced this pull request Apr 19, 2022
xzile pushed a commit to Interfolio/rebase that referenced this pull request Apr 19, 2022
cjw6k pushed a commit to SonarSoftwareInc/rebase that referenced this pull request Apr 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants