Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: Positioning of the framerate / frame time counter #48

Closed
karaokefreak opened this issue Oct 26, 2019 · 18 comments
Closed

Request: Positioning of the framerate / frame time counter #48

karaokefreak opened this issue Oct 26, 2019 · 18 comments

Comments

@karaokefreak
Copy link

Hi
I think I sorted all the problems out that I had when I initially started using this app. Now it works just fine. Thumbs up and thanks for your efforts!

However, I have a layout request

  1. I'd love to have a choice where to put the framerate counter (the digits) since the upper left corner is sometimes jammed with game stats and other HUD elements. having a choice between left or right corner and maybe a little margin for height adjustments (+ / - 100 Pixels?!?) would be great since changing the color doesn't always help.

  2. The graph for frame time and frame rate always start their measuring at the far right end of the matrix. However, a better place to see the actual state of the scene would be in the middle with an additional vertical line in the matrix to show it. This way you can see somewhat ahead what is coming up, and by showing the end of the graph coming up, it also shows when the recorded scene will end (which is a good feature when you want to use transitions between different scenes with FPS measurement).

Is there any chance to get this in the next build or so?

@cirquit
Copy link
Owner

cirquit commented Oct 28, 2019

The positioning of the Framerate Text is currently calculated by the amount of videos which are loaded so they appear in the left upper corner. What I can think of is to allow for the following options:

  • Left upper corner
  • Center
  • Right upper corner

Custom pixel-based positioning is quite cumbersome if they are not saved after closing the program so I'd try to not implement that until some caching is done.

As for the second feature I don't think I understand it correctly. What may be possible is to always skip x amount of frames, but showing the time + x framerate/-time, e.g looking in the future by x timesteps. What I don't understand about it how this is useful, as this may give a false impression about which scenes cause a slowdown. Please elaborate further!

@karaokefreak
Copy link
Author

Hi
Thanks for your reply.

About 1)
Putting the frame counter in a different corner or top center would already help a lot. Thanks!

About 2)
Please watch a video by "the digital foundry". Their Framerate graph will start and stop in the center of the screen, which makes it easier to see the actual state of the graph and lets you see what is coming in the next seconds. It's just more pleasing to the eye and provides a better overview on past, present and future of the framerate. And on top of that, their framerate & frame time graphs both run slower (so each frame-part of the graph is a little more narrow, which is nicer for the eye since the framerate graph doesn't run so fast at 60 FPS)

Here is a nice example on youtube
https://youtu.be/KREpHaA0Tbo?t=946

Thanks for your efforts!

@cirquit
Copy link
Owner

cirquit commented Nov 4, 2019

Ok so there are two issues then:

  1. Update the Graphs more slowly - we already have the Analysis range Option for that. You have to extend the interval to your desired timeframe. But maybe we can do a better job with the default value

  2. The centering of the current framerate in the graph. Now I think I understand what you meant. I'm actually quite surprised as I already thought about why DF had this centered vertical line in their graphs, now it makes sense.

I'm having mixed feelings about this feature - I definitely think it's not intuitive without an explanation and it slightly distorts the analysis as your usually can't see in the future.

If one knows about this, it makes the interpretation easier and allows the user to start to pay attention as to which frames cause the delay.

I'll think it may be possible to implement this by "holding off" the image stream by x frames and align it so value at the center of the graph shows the FPS of the currently rendered image.

What I'm missing is some visual explanation that the center of the graph shows the current value - I think that the vertical line is not enough to symbolize this. Maybe some sort of marker could do the job.

Do you have any suggestions for this or do you think this is usually not an issue with the target audience?

@karaokefreak
Copy link
Author

Hi, thanks for your reply.
Actually, people viewing such analysis-videos are quite used to the centred graph due to Digital foundry (and others) doing it this way for years. Actually they have been doing it this way for over a decade, even beforre they added a frame time graph. Their first FPS analysis video came out in December 2008
(see here https://www.youtube.com/watch?v=C_EY5fZRFbE)

But as an extra hint, you could add an extra arrow above the vertical line. Not too big, just enough to make it clear. I attached an example picture.
FramerateSugg
Thank you for your efforts

@cirquit
Copy link
Owner

cirquit commented Nov 5, 2019

I think this is a solid visual cue. If anybody else has some ideas, feel free to post them so we can discuss them.

I don't know when I'll have time to work on the next release as I'm swamped with RL work right now, but I think this is a doable feature.

@cirquit cirquit self-assigned this Nov 5, 2019
@karaokefreak
Copy link
Author

Hi again
Is there any news on this? I'm not trying to push, i am just curious when you might be able to work on this. :)

@cirquit
Copy link
Owner

cirquit commented Dec 16, 2019

Hi,

I'm planning to find some time for development over the winter break (25.12 - 07.01)

@karaokefreak
Copy link
Author

That sounds awesome, dude, thanks! Say, do you have a Paypal account, so I can donate a couple of beers to keep up your motivation?
I also made you an Icon for this app, since you have no icon yet. Just use it if you like it.
TR-Drop-Logo

@cirquit
Copy link
Owner

cirquit commented Jan 6, 2020

Just an FYI, I'm working on the features but I'm waiting for the response of some more experienced developers in the Qt Forum.

It seems like a very simple thing to have, but apparently having a dropdown list for every video in the Options pane is not easily possible.

@karaokefreak
Copy link
Author

Hi there
Happy New Year ;)
Are there any news by now concerning the update?

@karaokefreak
Copy link
Author

Hi again-... well, it's been quite a while since the last update.
As far as I understood, you had a problem with the menu system. But how about the centered Graph lines? Could you make an Update on TR drop that contains the centered Graph-Line, please?

@cirquit
Copy link
Owner

cirquit commented Dec 27, 2020

So I implemented the centering, it is now also configurable from the general settings.
image

It is kind of a pain in the ass, as I have to store the images which are processed but not visualized (until the graph reaches the center). So it uses ~ 3GB RAM with a 4k export and 180s analysis range. I also had to compile the program with 64-bit and not 32 bit as before for this to be possible, so hopefully this won't affect many users.

I did not implement the text positioning yet.

@karaokefreak
Copy link
Author

karaokefreak commented Dec 27, 2020

Hey man, that is awesome. I totally appreciate your efforts! Thanks a lot! It makes it so much better now! Can't wait for the release!

@cirquit
Copy link
Owner

cirquit commented Dec 27, 2020

I also implemented the fps text moving.

2020-12-27.22-34-16-1-encoded.mp4

I'll try to make a new release in the next few days.

@karaokefreak
Copy link
Author

Awesome. Looking forward to testing it

@cirquit
Copy link
Owner

cirquit commented Dec 28, 2020

Release is done. Feel free to write here if you find any problems with the discussed functionality. Otherwise please open a new issue!

@karaokefreak
Copy link
Author

Awesome. Will download it right away and check it soon! Thanks for your efforts

@cirquit
Copy link
Owner

cirquit commented Jan 6, 2021

Should all be solved for now.

@cirquit cirquit closed this as completed Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants