Revert "fix files with ' or " by using arg lists instead of strings (… #628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iromattia#581)" This reverts commit 431862a.
axu2
added a commit
to axu2/kcc
that referenced
this pull request
Dec 1, 2023
…trings (ciromattia#581)" (ciromattia#628)" This reverts commit b528dab.
axu2
added a commit
that referenced
this pull request
Dec 21, 2023
… of strings (#633) * Revert "Revert "fix files with ' or " by using arg lists instead of strings (#581)" (#628)" This reverts commit b528dab. * handle FileNotFoundError * modify unar handling * remove unneeded utf-8 encoding * dont uft-8 encode 7z * remove utf-8 encoding from 7z calls * don't extract stderr * add extraction error * edit error message * remove debug * remove kindlegen location from GUI * remove comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…#581)"
This reverts commit 431862a.
This actually caused issues when 7z and kindlegen aren't installed, will revisit later.