Fix SERVER_SRS_HOST_AUTO

[Camble]

This fixes the SERVER_SRS_HOST_AUTO by making use of net.get_server_host() on the client-side.

I've updated the auto-connect message to only send the port if SERVER_SRS_HOST_AUTO is enabled, otherwise it uses the original message with SERVER_SRS_HOST and SERVER_SRS_PORT.

I've removed the isAutoConnectMessage function in favour of regex matching. We try to get the port from the message, if this fails, fallback to matching on IP and Port.

[ciribob]

Thats a really interesting idea! I like this a lot as it reduces the message size as well.

Only comment would be to leave AUTO_HOST false by default (as thats the current behaviour) but otherwise very happy to merge.

Thanks!

[Camble]

Ah, sorry about that. I was under the impression the default was true prior to issues obtaining the IP address. I'll change it back.

[ciribob]

Gotcha! No worries. The Auto IP was always opt in as a surprising number of servers actually ran the SRS server on a different server (or at least public IP) to their actual DCS Server

I'll add this to the next release and do a bit of backwards compatibility testing as well. Thanks for the contribution!

[ciribob]

Ah sorry need to revert for now

the Port is optional on the autoconnect GameGUI (try Hoggit GAW) so it wont match that example

[ciribob]

Sorry should've put more detail! Yes port is optional (always was apparently - I forgot) - default is 5002 though so you can just insert that or change the regex to make :PORT optional

…

On Mon, Oct 23, 2023 at 11:15 AM Kenny Campbell ***@***.***> wrote: Was the port always optional? Is there a default? — Reply to this email directly, view it on GitHub <#676 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAGAEMGEHA3HJJTLT57P73TYAYYUDAVCNFSM6AAAAAA5NEEAFSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZUG43DGNBVGA> . You are receiving this because you modified the open/close state.Message ID: ***@***.***>

-- Regards, Ciaran