Fix Projections (needed for UPSERT support) #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The definition of `Projecting` had a small typo in it which made it impossible to construct `Projection`s in the way described in the documentation. We also add an UPSERT test case to the test suite that would have caught this.
shane-circuithub
force-pushed
the
fix-projection
branch
from
0dab6e6
to
5a9ccd4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The definition of
Projectinghad a small typo in it which made it impossible to constructProjections in the way described in the documentation.This partially fixes is #131 (but not completely because we could still do with better documentation in general around this).