-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finish event not firing #13
Comments
Sorry, i can't understand what you saying, i create a online demo further explanation. |
this is not working with angular 8 .. I am also facing same issue . |
Can confirm this is still an issue with Angular 7. The finished event is never firing, though normal events seem to still be working and you can work with those. A workaround for those still having an issue with the finished event: HTML: TS: |
In the demo you used angular 5. As of now Angular is in version 9. In the documentation you have a (done) event, not even that is being triggered. Which brings the issue that the doc says (done) instead of (finished). |
Thanks, working Angular v10 rc! :) |
Hi Daniel ,
It's working fine.
Thanks for support
Get Outlook for Android<https://aka.ms/ghei36>
…________________________________
From: Daniel Revzo Molnar <[email protected]>
Sent: Sunday, June 14, 2020 10:16:58 PM
To: cipchk/ngx-countdown <[email protected]>
Cc: Ankit kumar shukla <[email protected]>; Comment <[email protected]>
Subject: Re: [cipchk/ngx-countdown] Finish event not firing (#13)
Can confirm this is still an issue with Angular 7. The finished event is never firing, though normal events seem to still be working and you can work with those. A workaround for those still having an issue with the finished event:
HTML:
<countdown #countdown [config]="{leftTime: 5, demand: false}" (event)="timesUp($event)">$!h!:$!m!:$!s!</countdown>
TS:
timesUp(event) { if (event.action == "done") { console.log("Finished"); } }
Thanks, working Angular v10 rc! :)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub<#13 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ADGADEPJN6XDF5SD7BTQYKDRWT5IFANCNFSM4ENBDV7Q>.
|
@cipchk I am trying to fire an
onfinished
event when the countdown gets over. Here is what my html looks like:<countdown class="timer" [config]="config" (finished)="finishTest()">$!m!:$!s!</countdown>
The only issue is that the event if fired as soon as the component is loaded. In simple terms, if i kept the config as 10 seconds timer but the finished event is fired in 1st second itself. Any idea what is going wrong and also what other info can I provide for further help?
The text was updated successfully, but these errors were encountered: