Added comparison functions for floats and doubles… #2321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…way to do things like `double value; if( value == 0.0 ){}`.
…in favor of FLT_EPSILON and DBL_EPSILON.
|
Thanks for this Paul - these look like nice additions, and I'm inclined to merge this shortly unless anyone has any additional comments. |
…at relied on it. Also reverted back to using this defined EPSILON_VALUE, because it's larger and more appropriate than FLT_EPSILON or DBL_EPSILON in most cases, specifically the cases for which these functions were added to Cinder.
paulhoux
force-pushed
the
float-comparisons
branch
from
546ad63 to
f2eb0c6
Compare
|
Once accepted, please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…providing a safer way to do things like
double value; if( value == 0.0 ){}.Compared to previous versions of the code, I have explicitly added the
std::namespace toabs. While this is not necessary in Visual Studio (it already uses std::abs by default), it may be required for other compilers. Using the C++ functionstd::absif preferred over the C-functionfabsf.I also added versions for
doubles.