Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor & rename ringbuf metrics #2833

Merged
merged 3 commits into from
Aug 30, 2024
Merged

Refactor & rename ringbuf metrics #2833

merged 3 commits into from
Aug 30, 2024

Conversation

lambdanis
Copy link
Contributor

No description provided.

Copy link

netlify bot commented Aug 22, 2024

Deploy Preview for tetragon ready!

Name Link
🔨 Latest commit 8ea0da7
🔍 Latest deploy log https://app.netlify.com/sites/tetragon/deploys/66d195b344cf6c0008378661
😎 Deploy Preview https://deploy-preview-2833--tetragon.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@lambdanis lambdanis changed the title Pr/lambdanis/lost metrics Refactor & rename ringbuf metrics Aug 22, 2024
@lambdanis lambdanis marked this pull request as ready for review August 22, 2024 20:48
@lambdanis lambdanis requested review from mtardy and a team as code owners August 22, 2024 20:48
@lambdanis lambdanis added area/metrics Related to prometheus metrics release-note/minor This PR introduces a minor user-visible change labels Aug 22, 2024
@mtardy
Copy link
Member

mtardy commented Aug 29, 2024

Ouh sorry I missed this, let me take a quick look

Copy link
Member

@mtardy mtardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks innocent 😇

There are no functional changes in this commit, only moving code around to
improve readability and prevent confusing metrics reuse.

Signed-off-by: Anna Kapuscinska <[email protected]>
Use more consistent names for easier querying.

Signed-off-by: Anna Kapuscinska <[email protected]>
@lambdanis lambdanis merged commit ed28783 into main Aug 30, 2024
47 checks passed
@lambdanis lambdanis deleted the pr/lambdanis/lost-metrics branch August 30, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/metrics Related to prometheus metrics release-note/minor This PR introduces a minor user-visible change
Projects
Development

Successfully merging this pull request may close these issues.

2 participants