chore(deps): update docker.io/golangci/golangci-lint docker tag to v1.60.3 (main) #2813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cilium-renovate[bot]](https://avatars.githubusercontent.com/in/339224?s=60&v=4){kind=small}
cilium-renovate
bot
requested review from
willfindlay and
a team
as code owners
cilium-renovate
bot
added
release-blocker
cilium-renovate
bot
force-pushed
the
renovate/main-docker.io-golangci-golangci-lint-1.x
branch
from
8a80b05
to
06d8677
Compare
cilium-renovate
bot
changed the title
….60.3 Signed-off-by: cilium-renovate[bot] <134692979+cilium-renovate[bot]@users.noreply.github.com>
cilium-renovate
bot
force-pushed
the
renovate/main-docker.io-golangci-golangci-lint-1.x
branch
from
06d8677
to
3c7b64e
Compare
cilium-renovate
bot
changed the title
✅ Deploy Preview for tetragon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mtardy
reviewed
Aug 29, 2024
| } | ||
|
|
||
| func (tl tlog) Write(p []byte) (n int, err error) { | ||
| tl.Logf((string)(p)) | ||
| tl.Log(string(p)) |
There was a problem hiding this comment.
Hey @kkourt, I think it was a mistake here that maybe you wanted to use Logrus here and not the native testing Log functions. I also think that it doesn't really matter maybe? What do you think?
There was a problem hiding this comment.
I honestly don't remember, but change LGTM :)
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
Fix those issues: pkg/filters/caps.go:29:5 gosimple S1009: should omit nil check; len() for []github.com/cilium/tetragon/api/v1/tetragon.CapabilitiesType is defined as zero pkg/filters/caps.go:34:5 gosimple S1009: should omit nil check; len() for []github.com/cilium/tetragon/api/v1/tetragon.CapabilitiesType is defined as zero pkg/filters/caps.go:39:5 gosimple S1009: should omit nil check; len() for []github.com/cilium/tetragon/api/v1/tetragon.CapabilitiesType is defined as zero pkg/filters/caps.go:44:5 gosimple S1009: should omit nil check; len() for []github.com/cilium/tetragon/api/v1/tetragon.CapabilitiesType is defined as zero pkg/policyfilter/k8s_test.go:51:10 govet printf: non-constant format string in call to (*testing.common).Logf pkg/sensors/exec/exec_test.go:367:13 govet printf: non-constant format string in call to fmt.Printf pkg/sensors/exec/exec_test.go:496:13 govet printf: non-constant format string in call to fmt.Printf pkg/tracingpolicy/generictracingpolicy.go:231:26 govet printf: non-constant format string in call to fmt.Errorf Signed-off-by: Mahe Tardy <[email protected]>
mtardy
force-pushed
the
renovate/main-docker.io-golangci-golangci-lint-1.x
branch
from
693aaef
to
ec968c3
Compare
kkourt
approved these changes
Sep 2, 2024
mtardy
deleted the
renovate/main-docker.io-golangci-golangci-lint-1.x
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
v1.59.1->v1.60.3Release Notes
golangci/golangci-lint (docker.io/golangci/golangci-lint)
v1.60.3Compare Source
gosec: from81cda2ftoab3f6c1(fixG115false positives)v1.60.2Compare Source
gofmt: update to HEAD (go1.22)gofumpt: from 0.6.0 to 0.7.0gosec: fix G602 analyzergosec: from5f0084eto81cda2f(addsG115,G405,G406,G506,G507)staticcheck: from 0.5.0 to 0.5.1staticcheck: propagate Go versionwrapcheck: from 2.8.3 to 2.9.0exportloopref: deprecationv1.60.1Compare Source
errorlint: from 1.5.2 to 1.6.0exhaustruct: from 3.2.0 to 3.3.0 (recognize custom error values in return)fatcontext: from 0.2.2 to 0.4.0 (fix false positives for context stored in structs)gocognit: from 1.1.2 to 1.1.3gomodguard: from 1.3.2 to 1.3.3govet(printf): report non-constant format, no argslll: advertise max line length instead of just reporting failurerevive: from 1.3.7 to 1.3.9 (new rule:comments-density)sloglint: from 0.7.1 to 0.7.2spancheck: from 0.6.1 to 0.6.2staticcheck: from 0.4.7 to 0.5.0tenv: from 1.7.1 to 1.10.0 (remove reports on fuzzing)testifylint: from 1.3.1 to 1.4.3 (new options:formatter,suite-broken-parallel,suite-subtest-run)tparallel: from 0.3.1 to 0.3.2usestdlibvars: from 1.26.0 to 1.27.0 (fix false-positive with number used inside a mathematical operations)wsl: from 4.2.1 to 4.4.1unused: removeexported-is-usedoptiontypecheckissues should never be ignoredwslupdate documentation of the configurationConfiguration
📅 Schedule: Branch creation - "on monday and friday" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Renovate Bot.