api/ops: Remove MsgOp* constants #2799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MsgOp* constants were duplicating MSG_OP_*. There is no point in maintaining two lists, and MsgOp* constants weren't added for some new features. Let's keep MSG_OP_* for consistency with other types and bpf. Also remove MsgOpKfreeSkb (not used and not existing in bpf) and update metrics docs with missing opcodes. Signed-off-by: Anna Kapuscinska <[email protected]>
lambdanis
added
kind/cleanup
✅ Deploy Preview for tetragon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MsgOp*constants were duplicatingMSG_OP_*. There is no point in maintaining two lists, andMsgOp*constants weren't added for some new features. Let's keepMSG_OP_*for consistency with other types and bpf.Also remove
MsgOpKfreeSkb(not used and not existing in bpf) and update metrics docs with missing opcodes.