Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tetragon: persistent monitoring fixes #2795

Merged
merged 2 commits into from
Aug 13, 2024
Merged

tetragon: persistent monitoring fixes #2795

merged 2 commits into from
Aug 13, 2024

Conversation

olsajiri
Copy link
Contributor

adding more checks on related options plus some more adding some more comments

…option

If there's --release-pinned-bpf option enabled, we need to remove
previous sysfs instance right away, so don't bother renaming that.

Signed-off-by: Jiri Olsa <[email protected]>
Copy link

netlify bot commented Aug 13, 2024

Deploy Preview for tetragon ready!

Name Link
🔨 Latest commit 2051569
🔍 Latest deploy log https://app.netlify.com/sites/tetragon/deploys/66bb4d8179a29c0008de5b62
😎 Deploy Preview https://deploy-preview-2795--tetragon.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@olsajiri olsajiri added the release-note/minor This PR introduces a minor user-visible change label Aug 13, 2024
The effect of having both --release-pinned-bpf and --keep-sensors-on-exit options
enabled is that the previous sysfs instance will be removed early before the new
config is set. Not a big problem, but better to warn..

Signed-off-by: Jiri Olsa <[email protected]>
@olsajiri olsajiri marked this pull request as ready for review August 13, 2024 14:54
@olsajiri olsajiri requested a review from a team as a code owner August 13, 2024 14:54
@olsajiri olsajiri requested a review from kkourt August 13, 2024 19:03
@jrfastab jrfastab merged commit 25a43a0 into main Aug 13, 2024
41 checks passed
@jrfastab jrfastab deleted the pr/olsajiri/fixes branch August 13, 2024 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/minor This PR introduces a minor user-visible change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants