-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tetragon: Factor loader tailcall setup #2719
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for tetragon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
olsajiri
added
the
release-note/minor
This PR introduces a minor user-visible change
label
Jul 24, 2024
olsajiri
force-pushed
the
pr/olsajiri/tc
branch
2 times, most recently
from
July 31, 2024 09:42
fe8b41b
to
9beadfc
Compare
Passing tail call map directly instead of the name, so we can use directly some of its fields in future instead of its name. Signed-off-by: Jiri Olsa <[email protected]>
Tail call setup is property of the program, so let's move it in there. This will make the tail call setup much easier in following changes. Signed-off-by: Jiri Olsa <[email protected]>
Using program.SetTailCall for tracepoints and getting rid of the map name check for tail call setup. Signed-off-by: Jiri Olsa <[email protected]>
Using program.SetTailCall for kprobes and getting rid of the map name check for tail call setup. Signed-off-by: Jiri Olsa <[email protected]>
Using program.SetTailCall for uprobes and getting rid of the map name check for tail call setup. Signed-off-by: Jiri Olsa <[email protected]>
Using program.SetTailCall for lsm probes and getting rid of the map name check for tail call setup. Signed-off-by: Jiri Olsa <[email protected]>
Now when we have TcMap/Prefix in program.Program we can use it directly and remove it from program.LoadOpts. Signed-off-by: Jiri Olsa <[email protected]>
tpapagian
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
move tail call setup to the program layer and get rid of the tail call maps name checking