Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linter warnings in Dockerfiles #2657

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

lambdanis
Copy link
Contributor

Silly changes to fix linter warnings:

FromAsCasing: 'as' and 'FROM' keywords' casing do not match
LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format

Silly changes to fix linter warnings:
```
FromAsCasing: 'as' and 'FROM' keywords' casing do not match
LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format
```

Signed-off-by: Anna Kapuscinska <[email protected]>
@lambdanis lambdanis added the release-note/misc This PR makes changes that have no direct user impact. label Jul 11, 2024
@lambdanis lambdanis requested a review from a team as a code owner July 11, 2024 13:36
@lambdanis lambdanis requested a review from tpapagian July 11, 2024 13:36
Copy link
Member

@mtardy mtardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it a linter you ran locally?

@lambdanis
Copy link
Contributor Author

is it a linter you ran locally?

It's part of the images builds, locally and everywhere else.

@lambdanis lambdanis merged commit 3e86f3c into cilium:main Jul 11, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants