Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

syscallinfo: fix typo for oldlstat #2550

Merged
merged 1 commit into from
Jun 15, 2024
Merged

syscallinfo: fix typo for oldlstat #2550

merged 1 commit into from
Jun 15, 2024

Conversation

kkourt
Copy link
Contributor

@kkourt kkourt commented Jun 13, 2024

There seems to be a typo for SYS_OLDLSTAT. The name should be oldlstat rather than oldstat.

Looking at the i386/linux.go file:

$ grep -e 'OLDL\?STAT' ./pkg/syscallinfo/i386/linux.go
        SYS_OLDSTAT                      = 18
        SYS_OLDLSTAT                     = 84

Verified the number with:

$ cat oldlstat.c
int main(int argc, char **argv)
{
        printf("SYS_oldlstat:%d\n", SYS_oldlstat);
        return 0;
}
$ gcc -Wall -m32 oldlstat.c -o oldlstat
$ ./oldlstat
SYS_oldlstat:84

There seems to be a typo for SYS_OLDLSTAT. The name should be oldlstat
rather than oldstat.

Looking at the i386/linux.go file:
$ grep -e 'OLDL\?STAT' ./pkg/syscallinfo/i386/linux.go
        SYS_OLDSTAT                      = 18
        SYS_OLDLSTAT                     = 84

Verified the number with:
$ cat oldlstat.c
int main(int argc, char **argv)
{
        printf("SYS_oldlstat:%d\n", SYS_oldlstat);
        return 0;
}
$ gcc -Wall -m32 oldlstat.c -o oldlstat
$ ./oldlstat
SYS_oldlstat:84

Signed-off-by: Kornilios Kourtis <[email protected]>
@kkourt kkourt added the release-note/misc This PR makes changes that have no direct user impact. label Jun 13, 2024
@kkourt kkourt requested a review from a team as a code owner June 13, 2024 15:08
@kkourt kkourt requested a review from tixxdz June 13, 2024 15:08
@kkourt kkourt merged commit 96a12d9 into main Jun 15, 2024
41 checks passed
@kkourt kkourt deleted the pr/kkourt/oldlstat-fix branch June 15, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants