Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci/e2e] Uninstall Tetragon after each e2e test #2541

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

tpapagian
Copy link
Member

@tpapagian tpapagian commented Jun 11, 2024

Thanks for contributing! Please ensure your pull request adheres to the following guidelines:

  • All commits contain a well written commit message and are signed-off (see Submitting a pull request).
  • All code is covered by unit and/or end-to-end tests where feasible.
  • All generated files are updated if needed (see Making changes).
  • Provide a title or release-note blurb suitable for the release notes (see guidelines).
  • Update documentation and write an upgrade note if needed (see guidelines).
  • Are you a user of Tetragon? Please add yourself to the Users doc in the Cilium repository.

This PR uninstalls tetragon after each e2e test in order to remove any interference between tests.

Uninstall Tetragon after each e2e test.

@tpapagian tpapagian force-pushed the pr/apapag/cleanup-e2e-tests branch from 8938808 to c5415a4 Compare June 12, 2024 06:54
@tpapagian tpapagian added the release-note/ci This PR makes changes to the CI. label Jun 12, 2024
@tpapagian tpapagian force-pushed the pr/apapag/cleanup-e2e-tests branch 3 times, most recently from 1c2a07c to 5c2cee3 Compare June 14, 2024 10:52
@tpapagian tpapagian changed the title Test [ci/e2e] Uninstall Tetragon after each e2e test Jun 14, 2024
@tpapagian tpapagian marked this pull request as ready for review June 14, 2024 11:54
@tpapagian tpapagian requested a review from a team as a code owner June 14, 2024 11:54
In the case of Kind e2e tests we create a new kind cluster for each test
(which is inside docker), install cilium, tetragon, and tracing
policies. At the end of each test, we used to just destroy the kind
cluster. But the issue here is that eBPF programs are not removed from
the host. This commit uninstalls tetragon explicitly to remove all eBPF
programs and avoid interference between e2e tests.

This does not seem to be an issue when creating a kind cluster locally,
installing Tetragon and then deleting the kind cluster without
unistalling Tetragon. In that case, all programs seems to be removed.

This seems to be only an issue related to kind + lvh + e2e framework
and not on real production clusters.

Signed-off-by: Anastasios Papagiannis <[email protected]>
@tpapagian tpapagian force-pushed the pr/apapag/cleanup-e2e-tests branch from 5c2cee3 to 81a4e05 Compare June 17, 2024 10:31
@tpapagian tpapagian merged commit dd602b0 into main Jun 17, 2024
39 checks passed
@tpapagian tpapagian deleted the pr/apapag/cleanup-e2e-tests branch June 17, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/ci This PR makes changes to the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants