Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Fix a link in contribution guide #2496

Merged
merged 1 commit into from
May 31, 2024
Merged

docs: Fix a link in contribution guide #2496

merged 1 commit into from
May 31, 2024

Conversation

lambdanis
Copy link
Contributor

Fixes #2492

@lambdanis lambdanis added area/documentation Improvements or additions to documentation release-note/docs This PR updates the documentation. labels May 31, 2024
@lambdanis lambdanis requested review from mtardy and a team as code owners May 31, 2024 15:31
@netlify Netlify
Copy link

netlify bot commented May 31, 2024

✅ Deploy Preview for tetragon ready!

Name Link
🔨 Latest commit d2e2ee3
🔍 Latest deploy log https://app.netlify.com/sites/tetragon/deploys/6659ed6f7df8310008461f44
😎 Deploy Preview https://deploy-preview-2496--tetragon.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

mtardy
mtardy approved these changes May 31, 2024
View reviewed changes
Copy link
Member

@mtardy mtardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, I'm a bit surprised the PR link checker didn't detect that. That would be worth investigating but not sure I want to spend more time there!

@lambdanis lambdanis mentioned this pull request May 31, 2024
Closed
@mtardy mtardy merged commit d42d8bb into cilium:main May 31, 2024
11 checks passed
@mtardy
Copy link
Member

mtardy commented May 31, 2024

but not sure I want to spend more time there!

I have time management issues 😅 just trying to fix this led me to update Docsy and Hugo versions because I typed hugo server with my local latest version and the build failed, so I updated everything in #2497.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtardy mtardy mtardy approved these changes

Assignees
No one assigned
Labels
area/documentation Improvements or additions to documentation release-note/docs This PR updates the documentation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Documentation: broken links automatic report
2 participants
@lambdanis @mtardy