Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport/v1.0] Use gRPC-based liveness probe instead of tetra status #2481

Merged
merged 3 commits into from
May 29, 2024

Conversation

tpapagian
Copy link
Member

Backport #2478

Use gRPC-based liveness probe instead of tetra status.

@tpapagian tpapagian added the release-note/misc This PR makes changes that have no direct user impact. label May 29, 2024
@tpapagian tpapagian requested a review from a team as a code owner May 29, 2024 13:33
@tpapagian tpapagian requested review from tixxdz and removed request for a team May 29, 2024 13:33
tpapagian added 3 commits May 29, 2024 14:18
[upstream commit 6e17c79]

Now, we use tetra status command to report the status of tetragon
agent. This comes with some overheads as tetra binary has a lot of
additional functionality and it seems like an overkill to use that for
status reporting.

On the other hand, k8s supports liveness probes by using an gRPC
endpoint (i.e.
https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-startup-probes/#define-a-grpc-liveness-probe).
This patch first creates a dedicated gRPC server to report agent status that
can be used for the liveness probe.

Signed-off-by: Anastasios Papagiannis <[email protected]>
[upstream commit 2252857]

The previous commit introduced a gRPC server that can be used for
the liveness probe. This patch changes helm to make that default instead
of the tetra status based liveness probe.

The user can still use the tetra status based liveness probe by
defining a values file similar to:
tetragon:
  livenessProbe:
     timeoutSeconds: 60
     exec:
       command:
       - tetra
       - status
       - --server-address
       - "54321"
       - --retries
       - "5"

Signed-off-by: Anastasios Papagiannis <[email protected]>
This change introduced as part of
a37a56f
but we need this to fix some errors.

Signed-off-by: Anastasios Papagiannis <[email protected]>
@tpapagian tpapagian force-pushed the pr/apapag/backport_10_2478 branch from d1d3faf to 29d3622 Compare May 29, 2024 14:19
@tpapagian tpapagian requested a review from mtardy as a code owner May 29, 2024 14:19
@tpapagian tpapagian merged commit a69c321 into v1.0 May 29, 2024
30 checks passed
@tpapagian tpapagian deleted the pr/apapag/backport_10_2478 branch May 29, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants