Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release_template: also tag API module #2457

Merged
merged 1 commit into from
May 24, 2024
Merged

Conversation

kkourt
Copy link
Contributor

@kkourt kkourt commented May 22, 2024

Releasing multiple modules from the same repo, requires tags for each. Add a tag for the api/ modules in the release process.

Releasing multiple modules from the same repo, requires tags for each.
Add a tag for the api/ modules in the release process.

Signed-off-by: Kornilios Kourtis <[email protected]>
@kkourt kkourt requested a review from a team as a code owner May 22, 2024 15:00
@kkourt kkourt requested a review from kevsecurity May 22, 2024 15:00
Copy link

netlify bot commented May 22, 2024

Deploy Preview for tetragon ready!

Name Link
🔨 Latest commit 4ec64d4
🔍 Latest deploy log https://app.netlify.com/sites/tetragon/deploys/664e088cb6c3b30008151837
😎 Deploy Preview https://deploy-preview-2457--tetragon.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kkourt kkourt added the release-note/misc This PR makes changes that have no direct user impact. label May 22, 2024
Copy link
Member

@mtardy mtardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

aside, should we remove the -s? Is someone using that, should we start using it?

@kkourt
Copy link
Contributor Author

kkourt commented May 24, 2024

lgtm!

aside, should we remove the -s? Is someone using that, should we start using it?

I think we should use it if we can, so let's keep it.

@kkourt kkourt merged commit cf0a49d into main May 24, 2024
32 of 34 checks passed
@kkourt kkourt deleted the pr/kkourt/release-api-module branch May 24, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants