Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validate-crd: use SHAs for diff #2319

Merged
merged 1 commit into from
Apr 9, 2024
Merged

validate-crd: use SHAs for diff #2319

merged 1 commit into from
Apr 9, 2024

Conversation

kkourt
Copy link
Contributor

@kkourt kkourt commented Apr 9, 2024

The previous version did not work with forks.
Use pull_request.{base,head}.sha for the diff of files to fix above issue.

Fixes: #2255

The previous version did not work with forks.
Use pull_request.{base,head}.sha for the diff of files to fix above
issue.

Signed-off-by: Kornilios Kourtis <[email protected]>
@kkourt kkourt requested review from willfindlay and a team as code owners April 9, 2024 08:52
Copy link

netlify bot commented Apr 9, 2024

Deploy Preview for tetragon ready!

Name Link
🔨 Latest commit ed3006f
🔍 Latest deploy log https://app.netlify.com/sites/tetragon/deploys/661501b81311340008cdb111
😎 Deploy Preview https://deploy-preview-2319--tetragon.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kkourt kkourt added the release-note/ci This PR makes changes to the CI. label Apr 9, 2024
Copy link
Member

@mtardy mtardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kkourt kkourt merged commit cfe0eb3 into main Apr 9, 2024
37 of 38 checks passed
@kkourt kkourt deleted the pr/kkourt/crd-fix branch April 9, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/ci This PR makes changes to the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci: CRD version check fails on PRs from forks
2 participants