Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: fix a missing 'vendor' target in oci-hook #2283

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

mtardy
Copy link
Member

@mtardy mtardy commented Apr 2, 2024

It seems that it's a mistake from 606aa9a#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52R201. I was trying to rebase #2175 and discovered the issue.

@mtardy mtardy added the kind/bug Something isn't working label Apr 2, 2024
@mtardy mtardy requested a review from kkourt April 2, 2024 13:30
@mtardy mtardy requested a review from a team as a code owner April 2, 2024 13:30
@mtardy mtardy added the release-note/ci This PR makes changes to the CI. label Apr 2, 2024
@@ -208,7 +208,7 @@ install:
vendor:
$(MAKE) -C ./api vendor
$(MAKE) -C ./pkg/k8s vendor
$(MAKE) -C ./contrib/rthooks/tetragon-oci-hook
$(MAKE) -C ./contrib/rthooks/tetragon-oci-hook vendor
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kkourt kkourt merged commit 310d201 into main Apr 2, 2024
33 of 35 checks passed
@kkourt kkourt deleted the pr/mtardy/oci-hook-vendor branch April 2, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working release-note/ci This PR makes changes to the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants