Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: remove istio sidecar related code #649

Merged

Conversation

mhofstetter
Copy link
Member

We no longer build proxy images for istio, better just clean it up.

Hence, as an additional follow up to #448, this commit removes the Istio sidecar specific implementations (socket mark, ...).

@mhofstetter mhofstetter added the clean-up Changes not affecting release behavior (style, removal of deprecated or dead code) label Mar 18, 2024
@sayboras sayboras changed the title ceanup: remove istio related code cleanup: remove istio related code Mar 19, 2024
@mhofstetter mhofstetter force-pushed the pr/mhofstetter/rem-envoy-sidecar branch from abd9fb5 to 5dd3341 Compare March 19, 2024 15:51
cilium/socket_option.h Outdated Show resolved Hide resolved
@mhofstetter mhofstetter changed the title cleanup: remove istio related code cleanup: remove istio sidecar related code Mar 19, 2024
@mhofstetter mhofstetter marked this pull request as ready for review March 19, 2024 16:02
@mhofstetter mhofstetter requested a review from a team as a code owner March 19, 2024 16:02
@mhofstetter mhofstetter requested review from jrajahalme and removed request for a team March 19, 2024 16:02
We no longer build proxy images for istio, better just clean it up.

Hence, as an additional follow up to cilium#448, this commit removes the
Istio sidecar specific implementations (socket mark, ...).

Signed-off-by: Marco Hofstetter <[email protected]>
@mhofstetter mhofstetter force-pushed the pr/mhofstetter/rem-envoy-sidecar branch from 5dd3341 to 9855c66 Compare March 19, 2024 16:04
Copy link
Member

@jrajahalme jrajahalme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clean-up!

@jrajahalme jrajahalme added this pull request to the merge queue Mar 20, 2024
Merged via the queue into cilium:main with commit ab66d60 Mar 20, 2024
5 checks passed
@mhofstetter mhofstetter deleted the pr/mhofstetter/rem-envoy-sidecar branch March 20, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clean-up Changes not affecting release behavior (style, removal of deprecated or dead code)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants