Skip to content

Commit

Permalink
starter: fix Envoy program and argument order
Browse files Browse the repository at this point in the history
[ upstream commit 174c6af ]

Currently, in case of not passing the argument delimiter `--`, the arguments are
added before the actual program name. This results in errors starting up Envoy.

This commit fixes this by inserting the arguments at the end.

Fixes: #650

Signed-off-by: Marco Hofstetter <[email protected]>
  • Loading branch information
mhofstetter authored and jrajahalme committed May 3, 2024
1 parent fe4713b commit d6f5e53
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion starter/main.cc
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ int main(int argc, char** argv) {

if (!delimiter_present) {
// backwards compabitility: handle all args as Envoys if delimiter isn't present
envoy_args.insert(envoy_args.begin(), args.begin(), args.end());
envoy_args.insert(envoy_args.end(), args.begin(), args.end());
} else {
// parse arguments and split by delimiter "--"
// before: arguments for starter process
Expand Down

0 comments on commit d6f5e53

Please sign in to comment.