Fix: update readme after new tagging mechanic #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qmonnet
requested changes
Aug 6, 2024
thank you, applied the fix ! |
qmonnet
approved these changes
Aug 6, 2024
Following the pr cilium#286, update of the readme about how the tagging mechanic works Signed-off-by: Antony Reynaud <[email protected]>
Artyop
force-pushed
the
pr/fix-readme-new-tagging-mechanic
branch
from
e11301c
to
1abadf1
Compare
fixed that too, thanks a lot for the review ! |
|
I can't merge without the missing reviews. I'll request one from Tobias, as I think Daniel is out. |
tklauser
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the pr #286, update of the README.md about how the tagging mechanic works