Makefile: fix definition of PLATFORMS variable #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise the build will fail if PLATFORMS is not defined on make invocation. Fixes: 0ee97a0 ("Allow users to overwrite build platforms") Signed-off-by: Tobias Klauser <[email protected]>
Merged
borkmann
approved these changes
Mar 20, 2024
tklauser
added a commit
that referenced
this pull request
Mar 21, 2024
Currently images are only built (and pushed) on pushes to the master branch, i.e. once the PR is merged. This can lead to situations where the image build is broken by a PR but the breakage is only caught later on, see e.g. [1] and [2]. Fix this by also building the images on PRs but only push them to the registry for master pushes as previously. [1] #233 (comment) [2] #240 Signed-off-by: Tobias Klauser <[email protected]>
tklauser
added a commit
that referenced
this pull request
Mar 21, 2024
Currently images are only built (and pushed) on pushes to the master branch, i.e. once the PR is merged. This can lead to situations where the image build is broken by a PR but the breakage is only caught later on, see e.g. [1] and [2]. Fix this by also building the images on PRs but only push them to the registry for master pushes as previously. [1] #233 (comment) [2] #240 Signed-off-by: Tobias Klauser <[email protected]>
tklauser
added a commit
that referenced
this pull request
Mar 21, 2024
Currently images are only built (and pushed) on pushes to the master branch, i.e. once the PR is merged. This can lead to situations where the image build is broken by a PR but the breakage is only caught later on, see e.g. [1] and [2]. Fix this by also building the images on PRs but only push them to the registry for master pushes as previously. [1] #233 (comment) [2] #240 Signed-off-by: Tobias Klauser <[email protected]>
tklauser
added a commit
that referenced
this pull request
Mar 21, 2024
Currently images are only built (and pushed) on pushes to the master branch, i.e. once the PR is merged. This can lead to situations where the image build is broken by a PR but the breakage is only caught later on, see e.g. [1] and [2]. Fix this by also building the images on PRs but only push them to the registry for master pushes as previously. [1] #233 (comment) [2] #240 Signed-off-by: Tobias Klauser <[email protected]>
tklauser
added a commit
that referenced
this pull request
Mar 21, 2024
Currently images are only built (and pushed) on pushes to the master branch, i.e. once the PR is merged. This can lead to situations where the image build is broken by a PR but the breakage is only caught later on, see e.g. [1] and [2]. Fix this by also building the images on PRs but only push them to the registry for master pushes as previously. [1] #233 (comment) [2] #240 Signed-off-by: Tobias Klauser <[email protected]>
tklauser
added a commit
that referenced
this pull request
Mar 22, 2024
Currently images are only built (and pushed) on pushes to the master branch, i.e. once the PR is merged. This can lead to situations where the image build is broken by a PR but the breakage is only caught later on, see e.g. [1] and [2]. Fix this by also building the images on PRs but only push them to the registry for master pushes as previously. [1] #233 (comment) [2] #240 Signed-off-by: Tobias Klauser <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise the build will fail if PLATFORMS is not defined on make invocation.
Fixes: 0ee97a0 ("Allow users to overwrite build platforms")