Skip to content

Commit

Permalink
bump minimum Go to 1.21
Browse files Browse the repository at this point in the history 
1.22 has been released, bump minimum version to 1.21.

Signed-off-by: Lorenz Bauer <[email protected]>
  • Loading branch information
@lmb
lmb committed Feb 7, 2024
1 parent 38c3af9 commit b3432fb
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ env:
TMPDIR: /tmp
CI_MAX_KERNEL_VERSION: '6.6'
CI_MIN_CLANG_VERSION: '11'
go_version: '~1.21'
prev_go_version: '~1.20'
go_version: '~1.22'
prev_go_version: '~1.21'
# This needs to match whatever Netlify supports.
# Also defined in Pipfile.
python_version: '~3.8'
Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/cilium/ebpf

go 1.20
go 1.21.0

require (
github.com/go-quicktest/qt v1.101.0
Expand Down

4 comments on commit b3432fb

@alxn
Copy link
Contributor

@alxn alxn commented on b3432fb Feb 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to set this to 1.21.0 (vs 1.21) ?

@lmb
Copy link
Collaborator Author

@lmb lmb commented on b3432fb Feb 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, see https://cilium.slack.com/archives/C027KBX679U/p1708072798219249 and golang/go#62278 specifically

@lmb
Copy link
Collaborator Author

@lmb lmb commented on b3432fb Feb 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know if there is better guidance out there!

@alxn
Copy link
Contributor

@alxn alxn commented on b3432fb Feb 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm getting very cryptic error messages on greenkeeping the latest version when I go mod tidy -go=1.21

go: github.com/cilium/[email protected] requires [email protected], but 1.21 is requested

Let me bug my Go expert friends/colleagues and see - thanks for the references.

It does work with go mod tidy -go=1.21.0 of course...

Please sign in to comment.