client: make conn.UDPSize atomic to pacify -race #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As is, Conn is not safe to access concurrently, and the race detector
correctly identifies occurrences of this, by reporting races in
cilium/cilium:
Read at 0x00c00754eb90 by goroutine 3305340:
github.com/cilium/dns.(*Conn).ReadMsgHeader()
/go/src/github.com/cilium/cilium/vendor/github.com/cilium/dns/client.go:304 +0xc4
github.com/cilium/dns.(*Conn).ReadMsg()
/go/src/github.com/cilium/cilium/vendor/github.com/cilium/dns/client.go:274 +0x3d
github.com/cilium/dns.handler.func2()
/go/src/github.com/cilium/cilium/vendor/github.com/cilium/dns/shared_client.go:173 +0x15a
Previous write at 0x00c00754eb90 by goroutine 3305339:
github.com/cilium/dns.(*Client).SendContext()
/go/src/github.com/cilium/cilium/vendor/github.com/cilium/dns/client.go:242 +0xfe
github.com/cilium/dns.handler()
/go/src/github.com/cilium/cilium/vendor/github.com/cilium/dns/shared_client.go:251 +0x773
github.com/cilium/dns.(*SharedClient).ExchangeSharedContext.gowrap1()
/go/src/github.com/cilium/cilium/vendor/github.com/cilium/dns/shared_client.go:298 +0x5d
By making the size an atomic uint, the race detector will be pacified.
Signed-off-by: David Bimmler <[email protected]>
christarazi
approved these changes
Sep 9, 2024
|
What about other usages of |
Yeah, I realised this too. Really, the shared client should not be using the dns.Conn concurrently. I'll work on an actual solution to this, which might actually live in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As is, Conn is not safe to access concurrently, and the race detector correctly identifies occurrences of this, by reporting races in cilium/cilium:
By making the size an atomic uint, the race detector will be pacified.
Related: cilium/cilium#33897