forked from Wind-River/deepequal-gen
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gengo: Migrate to v2 #7
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sayboras
force-pushed
the
pr/tammach/gengo-v2
branch
3 times, most recently
from
October 2, 2024 05:00
32911b2
to
cd9181d
Compare
This commit is to migrate gengo to v2, as v1 is no longer maintained. Signed-off-by: Tam Mach <[email protected]>
sayboras
force-pushed
the
pr/tammach/gengo-v2
branch
from
October 2, 2024 10:59
cd9181d
to
4c4165f
Compare
sayboras
added a commit
to cilium/cilium
that referenced
this pull request
Oct 2, 2024
This is to pick up the changes in cilium/deepequal-gen#7. The main goal is to enable go 1.23 type alias again. Relates: #34988 Relates: cilium/deepequal-gen#7 Signed-off-by: Tam Mach <[email protected]>
sayboras
added a commit
to sayboras/cilium
that referenced
this pull request
Oct 2, 2024
All files are re-generated again as there is change in generation tools. Relates: kubernetes/kubernetes#127271 Relates: cilium/deepequal-gen#7 Relates: kubernetes-sigs/controller-tools#1061 Relates: 1d9d51f Signed-off-by: Tam Mach <[email protected]>
Ah thinking about this again, probably just need to wait for new controller-tools versions, so that we can upgrade in deps in cilium/cilium at once. Marking this as draft again. |
aanm
approved these changes
Oct 2, 2024
sayboras
added a commit
to cilium/cilium
that referenced
this pull request
Oct 2, 2024
This is to pick up the changes in cilium/deepequal-gen#7. The main goal is to enable go 1.23 type alias again. Relates: #34988 Relates: cilium/deepequal-gen#7 Signed-off-by: Tam Mach <[email protected]>
sayboras
added a commit
to sayboras/cilium
that referenced
this pull request
Oct 3, 2024
All files are re-generated again as there is change in generation tools. Relates: kubernetes/kubernetes#127271 Relates: cilium/deepequal-gen#7 Relates: kubernetes-sigs/controller-tools#1061 Relates: 1d9d51f Signed-off-by: Tam Mach <[email protected]>
sayboras
added a commit
to sayboras/cilium
that referenced
this pull request
Oct 7, 2024
All files are re-generated again as there is change in generation tools. Relates: kubernetes/kubernetes#127271 Relates: cilium/deepequal-gen#7 Relates: kubernetes-sigs/controller-tools#1061 Relates: 1d9d51f Signed-off-by: Tam Mach <[email protected]>
sayboras
added a commit
to sayboras/cilium
that referenced
this pull request
Oct 15, 2024
All files are re-generated again as there is change in generation tools. Relates: kubernetes/kubernetes#127271 Relates: cilium/deepequal-gen#7 Relates: kubernetes-sigs/controller-tools#1061 Relates: 1d9d51f Signed-off-by: Tam Mach <[email protected]>
sayboras
added a commit
to sayboras/cilium
that referenced
this pull request
Oct 15, 2024
All files are re-generated again as there is change in generation tools. Relates: kubernetes/kubernetes#127271 Relates: cilium/deepequal-gen#7 Relates: kubernetes-sigs/controller-tools#1061 Relates: 1d9d51f Signed-off-by: Tam Mach <[email protected]>
sayboras
added a commit
to cilium/cilium
that referenced
this pull request
Oct 15, 2024
All files are re-generated again as there is change in generation tools. Relates: kubernetes/kubernetes#127271 Relates: cilium/deepequal-gen#7 Relates: kubernetes-sigs/controller-tools#1061 Relates: 1d9d51f Signed-off-by: Tam Mach <[email protected]>
sayboras
added a commit
to cilium/cilium
that referenced
this pull request
Oct 16, 2024
All files are re-generated again as there is change in generation tools. Relates: kubernetes/kubernetes#127271 Relates: cilium/deepequal-gen#7 Relates: kubernetes-sigs/controller-tools#1061 Relates: 1d9d51f Signed-off-by: Tam Mach <[email protected]>
sayboras
added a commit
to cilium/cilium
that referenced
this pull request
Oct 16, 2024
All files are re-generated again as there is change in generation tools. Relates: kubernetes/kubernetes#127271 Relates: cilium/deepequal-gen#7 Relates: kubernetes-sigs/controller-tools#1061 Relates: 1d9d51f Signed-off-by: Tam Mach <[email protected]>
sayboras
added a commit
to cilium/cilium
that referenced
this pull request
Oct 16, 2024
All files are re-generated again as there is change in generation tools. Relates: kubernetes/kubernetes#127271 Relates: cilium/deepequal-gen#7 Relates: kubernetes-sigs/controller-tools#1061 Relates: 1d9d51f Signed-off-by: Tam Mach <[email protected]>
sayboras
added a commit
to cilium/cilium
that referenced
this pull request
Oct 17, 2024
All files are re-generated again as there is change in generation tools. Relates: kubernetes/kubernetes#127271 Relates: cilium/deepequal-gen#7 Relates: kubernetes-sigs/controller-tools#1061 Relates: 1d9d51f Signed-off-by: Tam Mach <[email protected]>
sayboras
added a commit
to cilium/cilium
that referenced
this pull request
Oct 19, 2024
All files are re-generated again as there is change in generation tools. Relates: kubernetes/kubernetes#127271 Relates: cilium/deepequal-gen#7 Relates: kubernetes-sigs/controller-tools#1061 Relates: 1d9d51f Signed-off-by: Tam Mach <[email protected]>
sayboras
added a commit
to cilium/cilium
that referenced
this pull request
Oct 27, 2024
All files are re-generated again as there is change in generation tools. Relates: kubernetes/kubernetes#127271 Relates: cilium/deepequal-gen#7 Relates: kubernetes-sigs/controller-tools#1061 Relates: 1d9d51f Signed-off-by: Tam Mach <[email protected]>
sayboras
added a commit
to cilium/cilium
that referenced
this pull request
Nov 1, 2024
All files are re-generated again as there is change in generation tools. Relates: kubernetes/kubernetes#127271 Relates: cilium/deepequal-gen#7 Relates: kubernetes-sigs/controller-tools#1061 Relates: 1d9d51f Signed-off-by: Tam Mach <[email protected]>
sayboras
added a commit
to cilium/cilium
that referenced
this pull request
Nov 1, 2024
All files are re-generated again as there is change in generation tools. Relates: kubernetes/kubernetes#127271 Relates: cilium/deepequal-gen#7 Relates: kubernetes-sigs/controller-tools#1061 Relates: 1d9d51f Signed-off-by: Tam Mach <[email protected]>
sayboras
added a commit
to cilium/cilium
that referenced
this pull request
Nov 5, 2024
All files are re-generated again as there is change in generation tools. Relates: kubernetes/kubernetes#127271 Relates: cilium/deepequal-gen#7 Relates: kubernetes-sigs/controller-tools#1061 Relates: 1d9d51f Signed-off-by: Tam Mach <[email protected]>
sayboras
added a commit
to cilium/cilium
that referenced
this pull request
Nov 7, 2024
All files are re-generated again as there is change in generation tools. Relates: kubernetes/kubernetes#127271 Relates: cilium/deepequal-gen#7 Relates: kubernetes-sigs/controller-tools#1061 Relates: 1d9d51f Signed-off-by: Tam Mach <[email protected]>
sayboras
added a commit
to cilium/cilium
that referenced
this pull request
Nov 15, 2024
All files are re-generated again as there is change in generation tools. Relates: kubernetes/kubernetes#127271 Relates: cilium/deepequal-gen#7 Relates: kubernetes-sigs/controller-tools#1061 Relates: 1d9d51f Signed-off-by: Tam Mach <[email protected]>
sayboras
added a commit
to cilium/cilium
that referenced
this pull request
Nov 15, 2024
All files are re-generated again as there is change in generation tools. Relates: kubernetes/kubernetes#127271 Relates: cilium/deepequal-gen#7 Relates: kubernetes-sigs/controller-tools#1061 Relates: 1d9d51f Signed-off-by: Tam Mach <[email protected]>
sayboras
added a commit
to cilium/cilium
that referenced
this pull request
Nov 25, 2024
All files are re-generated again as there is change in generation tools. Relates: kubernetes/kubernetes#127271 Relates: cilium/deepequal-gen#7 Relates: kubernetes-sigs/controller-tools#1061 Relates: 1d9d51f Signed-off-by: Tam Mach <[email protected]>
sayboras
added a commit
to cilium/cilium
that referenced
this pull request
Nov 27, 2024
All files are re-generated again as there is change in generation tools. Relates: kubernetes/kubernetes#127271 Relates: cilium/deepequal-gen#7 Relates: kubernetes-sigs/controller-tools#1061 Relates: 1d9d51f Signed-off-by: Tam Mach <[email protected]>
sayboras
added a commit
to cilium/cilium
that referenced
this pull request
Nov 28, 2024
All files are re-generated again as there is change in generation tools. Relates: kubernetes/kubernetes#127271 Relates: cilium/deepequal-gen#7 Relates: kubernetes-sigs/controller-tools#1061 Relates: 1d9d51f Signed-off-by: Tam Mach <[email protected]>
sayboras
added a commit
to cilium/cilium
that referenced
this pull request
Nov 28, 2024
All files are re-generated again as there is change in generation tools. Relates: kubernetes/kubernetes#127271 Relates: cilium/deepequal-gen#7 Relates: kubernetes-sigs/controller-tools#1061 Relates: 1d9d51f Signed-off-by: Tam Mach <[email protected]>
sayboras
added a commit
to cilium/cilium
that referenced
this pull request
Nov 28, 2024
All files are re-generated again as there is change in generation tools. Relates: kubernetes/kubernetes#127271 Relates: cilium/deepequal-gen#7 Relates: kubernetes-sigs/controller-tools#1061 Relates: 1d9d51f Signed-off-by: Tam Mach <[email protected]>
sayboras
added a commit
to cilium/cilium
that referenced
this pull request
Nov 28, 2024
All files are re-generated again as there is change in generation tools. Relates: kubernetes/kubernetes#127271 Relates: cilium/deepequal-gen#7 Relates: kubernetes-sigs/controller-tools#1061 Relates: 1d9d51f Signed-off-by: Tam Mach <[email protected]>
github-merge-queue bot
pushed a commit
to cilium/cilium
that referenced
this pull request
Nov 28, 2024
All files are re-generated again as there is change in generation tools. Relates: kubernetes/kubernetes#127271 Relates: cilium/deepequal-gen#7 Relates: kubernetes-sigs/controller-tools#1061 Relates: 1d9d51f Signed-off-by: Tam Mach <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit is to migrate gengo to v2, as v1 is no longer maintained1.
Testing
Testing was done locally with
make test
, as well with cilium/cilium repo in this PR cilium/cilium#34988Testing with cilium/cilium
Footnotes
https://github.com/kubernetes/gengo/pull/281#issuecomment-2374353462 ↩