fix(rbac): fix sonar cloud issues for rbac-backend plugin (janus-idp#…

…1619) Signed-off-by: Oleksandr Andriienko <[email protected]>
ciiay · May 14, 2024 · bf93354 · bf93354
1 parent bd92be8
commit bf93354
Showing 1 changed file with 5 additions and 7 deletions.
diff --git a/plugins/rbac-backend/src/role-manager/ancestor-search-memo.ts b/plugins/rbac-backend/src/role-manager/ancestor-search-memo.ts
@@ -147,7 +147,6 @@ export class AncestorSearchMemo {
       return;
     }
 
-    const groupsRefs = new Set<string>();
     const groupName = `group:${group.metadata.namespace?.toLocaleLowerCase(
       'en-US',
     )}/${group.metadata.name.toLocaleLowerCase('en-US')}`;
@@ -161,13 +160,12 @@ export class AncestorSearchMemo {
     if (parentGroup) {
       const parentName = `group:${group.metadata.namespace?.toLocaleLowerCase(
         'en-US',
-      )}/${parent.toLocaleLowerCase('en-US')}`;
+      )}/${parentGroup.metadata.name.toLocaleLowerCase('en-US')}`;
       memo.setEdge(parentName, groupName);
-      groupsRefs.add(parentName);
-    }
 
-    if (groupsRefs.size > 0 && memo.isAcyclic()) {
-      this.traverseGroups(memo, parentGroup!, allGroups, depth);
+      if (memo.isAcyclic()) {
+        this.traverseGroups(memo, parentGroup, allGroups, depth);
+      }
     }
   }
 
@@ -194,7 +192,7 @@ export class AncestorSearchMemo {
     );
 
     if (parentGroup && memo.isAcyclic()) {
-      this.traverseRelations(memo, parentGroup!, allRelations, depth);
+      this.traverseRelations(memo, parentGroup, allRelations, depth);
     }
   }