feat(rbac): implement a file watcher for csv reloads (janus-idp#1587)

* feat(rbac): implement a file watcher for csv reloads * feat(rbac): minor fixes * feat(rbac): minor fixes * feat(rbac): update to use new auth backend service * fix(rbac): fix the error handling for the RBAC file watcher Signed-off-by: Oleksandr Andriienko <[email protected]> --------- Signed-off-by: Oleksandr Andriienko <[email protected]> Co-authored-by: Oleksandr Andriienko <[email protected]>
ciiay · May 14, 2024 · 62fcafc · 62fcafc
1 parent 7d9ee11
commit 62fcafc
Show file tree

Hide file tree

Showing 21 changed files with 1,063 additions and 1,508 deletions.
diff --git a/plugins/rbac-backend/package.json b/plugins/rbac-backend/package.json
@@ -39,6 +39,8 @@
     "@janus-idp/backstage-plugin-rbac-common": "1.4.2",
     "@janus-idp/backstage-plugin-rbac-node": "1.1.1",
     "casbin": "^5.27.1",
+    "chokidar": "^3.6.0",
+    "csv-parse": "^5.5.5",
     "express": "^4.18.2",
     "express-promise-router": "^4.1.1",
     "knex": "^3.0.0",

diff --git a/plugins/rbac-backend/src/__fixtures__/data/invalid-csv/duplicate-policies-actions.csv b/plugins/rbac-backend/src/__fixtures__/data/invalid-csv/duplicate-policies-actions.csv
diff --git a/plugins/rbac-backend/src/__fixtures__/data/invalid-csv/duplicate-policy.csv b/plugins/rbac-backend/src/__fixtures__/data/invalid-csv/duplicate-policy.csv
@@ -7,3 +7,6 @@ p, role:default/catalog-writer, catalog.entity.create, use, allow
 p, role:default/catalog-writer, catalog.entity.create, use, allow
 
 p, role:default/catalog-writer, catalog-entity, delete, allow
+
+p, role:default/duplication-effect, catalog-entity, update, allow
+p, role:default/duplication-effect, catalog-entity, update, deny
diff --git a/plugins/rbac-backend/src/__fixtures__/data/invalid-csv/entityref-policy.csv b/plugins/rbac-backend/src/__fixtures__/data/invalid-csv/entityref-policy.csv
diff --git a/plugins/rbac-backend/src/__fixtures__/data/invalid-csv/error-policy.csv b/plugins/rbac-backend/src/__fixtures__/data/invalid-csv/error-policy.csv
@@ -0,0 +1,4 @@
+g, user:default/, role:default/catalog-deleter
+g, user:default/test, role:default/
+p, role:default/, catalog.entity.create, use, allow
+p, role:default/test, catalog.entity.create, delete, temp
diff --git a/plugins/rbac-backend/src/__fixtures__/data/invalid-csv/permission-policy.csv b/plugins/rbac-backend/src/__fixtures__/data/invalid-csv/permission-policy.csv
diff --git a/plugins/rbac-backend/src/__fixtures__/data/invalid-csv/role-entityref-policy.csv b/plugins/rbac-backend/src/__fixtures__/data/invalid-csv/role-entityref-policy.csv
diff --git a/plugins/rbac-backend/src/__fixtures__/data/valid-csv/simple-policy.csv b/plugins/rbac-backend/src/__fixtures__/data/valid-csv/simple-policy.csv
@@ -0,0 +1,2 @@
+g, user:default/guest, role:default/catalog-writer
+p, role:default/catalog-writer, catalog-entity, update, allow
diff --git a/plugins/rbac-backend/src/__fixtures__/data/valid-csv/updated-rbac-policy.csv b/plugins/rbac-backend/src/__fixtures__/data/valid-csv/updated-rbac-policy.csv
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		g, user:default/guest, role:default/catalog-writer
		p, role:default/catalog-writer, catalog-entity, update, allow