feat: Expanded on binary string generation #883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l distribution Added two functions to number.h, which are overloads of each other. One will generate a number on a normal distribution given a mean and standard deviation, the other does the same but limits the output to a certain minimum and maximum value Added the relevant unit tests to number_test.cpp
-Added functionality to generate a binary string which has a decimal equivalent within a specified range -Removed use of unisgned integers, as they can lead to unintended overflows
cieslarmichal
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Added a new function
std::string binary(int min, int max)which generates a binary string with its equivalent decimal value being within the specified range (inclusive).-Removed use of unisgned integers, as they can lead to unintended overflows
-Added relevant unit tests for the new
std::string binary(int min, int max)function