refactor: Refactored all of randomElement related functions and iterators to use ranges instead #843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ecessary headers + range error
Everything now uses ranges instead of iterators, much cleaner and easier
…tedSizeRandomElement
cieslarmichal
approved these changes
Aug 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With all of these functions using ranges instead of iterators, all you have to do is just pass the container straight since these cover all overloads.
Instead of using a pair of iterators you can use
ranges::subrange(start, end)instead etcThese algos are also a lot more optimized and follow the best practices.
The first algo which is multipass is specifically for random_accsess and forward / sized ranges. Every other type of range that is basic like input_range uses a single pass approach.