Add separated compiler warnings cmake file #622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Uilian Ries <[email protected]>
00thirdeye00
pushed a commit
to 00thirdeye00/faker-cxx
that referenced
this pull request
Jun 20, 2024
Signed-off-by: Uilian Ries <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding compiler warning directly in CMakeLists.txt can be messy when you want to have multiple compilers supported and multiple warnings.
This PR follows the idea recommended by https://github.com/cpp-best-practices/ :
Use a separated CMake file with all compiler warnings, and export it as a function.
The function can receive compiler custom compiler flags too, so users will have a flexible build. The Warning as error is not enable by default, but can be when defining
-DWARNINGS_AS_ERRORS=ON