feat: Implement dataUri function for SVG generation #1035
+187
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cieslarmichal
requested changes
Jan 15, 2025
Comment on lines
+26
to
+28
| src/modules/image.cpp | ||
| src/modules/base64.cpp | ||
| ) |
There was a problem hiding this comment.
they shouldnt be added here (in main Cmakelists), but in src's Cmakelists (https://github.com/cieslarmichal/faker-cxx/blob/main/src/CMakeLists.txt)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the
dataUrifunction, which generates a random data URI containing either a URL-encoded SVG image or a Base64-encoded SVG image. It includes options for width, height, color, and type.Reason for Changes
This feature allows users to easily generate SVG images in a data URI format, which is useful for embedding images directly in HTML.
Testing
I added unit tests for the
dataUrifunction to ensure it generates valid SVG and Base64 URIs. All tests pass successfully.Related Issues
Fixes #1024: add dataUri function to Image module
Additional Notes
Currently, the function only supports basic colors. Future work could include support for gradients.