Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate Sport module from class to functions within sport namespace #684

Closed
cieslarmichal opened this issue Jun 16, 2024 · 0 comments · Fixed by #717
Closed

migrate Sport module from class to functions within sport namespace #684

cieslarmichal opened this issue Jun 16, 2024 · 0 comments · Fixed by #717
Labels
good first issue Good for newcomers

Comments

@cieslarmichal
Copy link
Owner

No description provided.

@cieslarmichal cieslarmichal added the good first issue Good for newcomers label Jun 16, 2024
00thirdeye00 added a commit to 00thirdeye00/faker-cxx that referenced this issue Jun 24, 2024
@00thirdeye00
refactor: sport module migrate (cieslarmichal#684)
582f3ac 
sport module migration from class to functions within sport namespace

Signed-off-by: Guru Mehar Rachaputi <[email protected]>
@cieslarmichal cieslarmichal linked a pull request Jun 24, 2024 that will close this issue
refactor: sport module migrate (#684) #717
Merged
00thirdeye00 added a commit to 00thirdeye00/faker-cxx that referenced this issue Jun 24, 2024
@00thirdeye00
refactor: sport module migrate (cieslarmichal#684)
259003a 
	1. sport module migration from class to functions within sport namespace

	2. changed function name from sport() to sportName()

	3. changelog updated

Signed-off-by: Guru Mehar Rachaputi <[email protected]>
cieslarmichal pushed a commit that referenced this issue Jun 24, 2024
@00thirdeye00
refactor: sport module migrate (#684) (#717)
4fd336c 
* refactor: sport module migrate (#684)

sport module migration from class to functions within sport namespace

Signed-off-by: Guru Mehar Rachaputi <[email protected]>

* Update Sport.h

Changed sport() function to sportName()

* Update Sport.cpp

Changed sport() to sportName()

* Update SportData.h

Changed "Sport" namespace to lowercase "sport"

* Update SportTest.cpp

Change sport() to sportName() and "Sport" to lowercase "sport" in sport namespace

* refactor: sport module migrate (#684)

	1. sport module migration from class to functions within sport namespace

	2. changed function name from sport() to sportName()

	3. changelog updated

Signed-off-by: Guru Mehar Rachaputi <[email protected]>

---------

Signed-off-by: Guru Mehar Rachaputi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: sport module migrate (#684) 00thirdeye00/faker-cxx
1 participant
@cieslarmichal