Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to Gaussian random number generation in static methods of RandomVariates #319

Merged
merged 3 commits into from
May 30, 2024

Conversation

cicirello
Copy link
Owner

Summary

Improved Gaussian random number generation in static methods of RandomVariates to choose between internal implementation of original ziggurat algorithm (for Java legacy random number generators Random and SecureRandom) or the Java API implementation of the modified ziggurat for all others (internal change).

Closing Issues

Closes #316

Types of changes

  • I have read the CONTRIBUTING document.
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvements to existing code, such as refactoring or optimizations (non-breaking)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@cicirello cicirello added enhancement New feature or request refactor labels May 30, 2024
@cicirello cicirello self-assigned this May 30, 2024
Copy link
Contributor

JaCoCo Test Coverage Summary Statistics

  • Coverage: 99.88624729837333%
  • Branches: 100%

@cicirello cicirello merged commit b606f43 into main May 30, 2024
6 checks passed
@cicirello cicirello deleted the gaussian-316 branch May 30, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactor
Development

Successfully merging this pull request may close these issues.

Revise RandomVariates.nextGaussian to use our ziggurat impl only for the legacy generators
1 participant