-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Placeholder component for power select multiple #817
base: master
Are you sure you want to change the base?
Changes from 4 commits
25ef8ac
fcfc309
6e5129f
8285806
a150e25
c021e61
13ad5b5
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16,8 +16,8 @@ | |
{{/if}} | ||
</li> | ||
{{else}} | ||
{{#if (and placeholder (not searchEnabled))}} | ||
<span class="ember-power-select-placeholder">{{placeholder}}</span> | ||
{{#if (not-eq placeholder maybePlaceholder)}} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is changing the logic and concerns me. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. no you are right, i just realized this myself and am correcting it :) thx for the review |
||
{{component placeholderComponent placeholder=placeholder}} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. One last comment. The way the placeholder component works in the single component is that you render it, and it already check if its In think that you simplify this to {{#if (not searchEnabled)}}
{{component placeholderComponent placeholder=placeholder}}
{{/if}} |
||
{{/if}} | ||
{{/each}} | ||
{{#if searchEnabled}} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since you are not going to render this placeholder if the search is disabled, I think that you don't need this code.