Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @searchFieldPosition argument #1784

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alex-ju
Copy link
Contributor

@alex-ju alex-ju commented Apr 16, 2024

Summary

Follow-up on #1752, gradually introducing @searchFieldPosition (after-options | trigger).

Description

<PowerSelect /> instances will have @searchFieldPosition set to before-options by default.
<PowerSelectMultiple /> instances will have @searchFieldPosition set to trigger by default with the option to change it to before-options.

<PowerSelectMultiple @searchEnabled={{true}} @searchFieldPosition="before-options" /> instances will have a search input placed in the dropdown, before the options, acting exactly as it currently does in <PowerSelect @searchEnabled={{true}} />.

`<PowerSelect />` instances will have `@searchFieldPosition` set to `before-options` by default. `<PowerSelectMultiple />` instances will have `@searchFieldPosition` set to `trigger` by default with the option to change it to `before-options`.
@alex-ju alex-ju marked this pull request as ready for review April 16, 2024 15:25
@mkszepp
Copy link
Collaborator

mkszepp commented Apr 18, 2024

@alex-ju thank you... i will look to find time in next days to review it

@mkszepp
Copy link
Collaborator

mkszepp commented Apr 22, 2024

@alex-ju i have tested passing @searchFieldPosition for multiple and single select.
Multiple works great, but the @searchFieldPosition="trigger" on single doesn't work atm.

Do you have time to add also that option for single select?

@alex-ju
Copy link
Contributor Author

alex-ju commented Apr 22, 2024

@alex-ju i have tested passing @searchFieldPosition for multiple and single select. Multiple works great, but the @searchFieldPosition="trigger" on single doesn't work atm.

Do you have time to add also that option for single select?

I had a start on the single select as well, but it requires a bit more attention (esp on the a11y and focus management) so I was hoping to address it in a follow-up PR.

@mkszepp
Copy link
Collaborator

mkszepp commented Apr 22, 2024

I had a start on the single select as well, but it requires a bit more attention (esp on the a11y and focus management) so I was hoping to address it in a follow-up PR.

ah, understood...
i would like to add in same PR, because we need to add the new paramenter in docs, so maybe other peoples are reporting us that the new paramenter is not working.

@alex-ju
Copy link
Contributor Author

alex-ju commented Apr 22, 2024

I had a start on the single select as well, but it requires a bit more attention (esp on the a11y and focus management) so I was hoping to address it in a follow-up PR.

ah, understood... i would like to add in same PR, because we need to add the new paramenter in docs, so maybe other peoples are reporting us that the new paramenter is not working.

makes sense, will try to carry on with this PR then when time allows

@alex-ju
Copy link
Contributor Author

alex-ju commented Jul 1, 2024

@mkszepp an accessible implementation of @searchFieldPosition="trigger" on single selection turns out to be rather complex. would you consider gradually introducing all combinations, by first getting @searchFieldPosition="after-options" for multiple selection?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants