-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add @searchFieldPosition
argument
#1784
base: master
Are you sure you want to change the base?
Conversation
`<PowerSelect />` instances will have `@searchFieldPosition` set to `before-options` by default. `<PowerSelectMultiple />` instances will have `@searchFieldPosition` set to `trigger` by default with the option to change it to `before-options`.
@alex-ju thank you... i will look to find time in next days to review it |
@alex-ju i have tested passing Do you have time to add also that option for single select? |
I had a start on the single select as well, but it requires a bit more attention (esp on the a11y and focus management) so I was hoping to address it in a follow-up PR. |
ah, understood... |
makes sense, will try to carry on with this PR then when time allows |
@mkszepp an accessible implementation of |
Summary
Follow-up on #1752, gradually introducing
@searchFieldPosition
(after-options
|trigger
).Description
<PowerSelect />
instances will have@searchFieldPosition
set tobefore-options
by default.<PowerSelectMultiple />
instances will have@searchFieldPosition
set totrigger
by default with the option to change it tobefore-options
.<PowerSelectMultiple @searchEnabled={{true}} @searchFieldPosition="before-options" />
instances will have a search input placed in the dropdown, before the options, acting exactly as it currently does in<PowerSelect @searchEnabled={{true}} />
.