Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow @glimmer/component v2 #941

Merged
merged 6 commits into from
Nov 12, 2024
Merged

Allow @glimmer/component v2 #941

merged 6 commits into from
Nov 12, 2024

Conversation

mkszepp
Copy link
Collaborator

@mkszepp mkszepp commented Nov 11, 2024

No description provided.

@mkszepp
Copy link
Collaborator Author

mkszepp commented Nov 11, 2024

Blocked by emberjs/ember.js#20790

@Techn1x
Copy link
Contributor

Techn1x commented Nov 12, 2024

I'm surprised the tests are failing even though glimmer/component v1 was specified for them in the ember-try config

@mkszepp
Copy link
Collaborator Author

mkszepp commented Nov 12, 2024

Its a problem inside mono repo with pnpm and one lock file...
We were running in same issue with test helper in power select... only fix is to modify ci script... in eps it has passed tests

@mkszepp
Copy link
Collaborator Author

mkszepp commented Nov 12, 2024

We force now @glimmer/component v1 for ember <= 4.8 cause of reported bug emberjs/ember.js#20790. When the bug is fixed in glimmer v2 we can safely remove in ember-try...

@mkszepp mkszepp merged commit 45d9029 into master Nov 12, 2024
20 checks passed
@mkszepp mkszepp deleted the allow-glimmer-component-v2 branch November 12, 2024 06:25
@Techn1x
Copy link
Contributor

Techn1x commented Nov 12, 2024

Its a problem inside mono repo with pnpm and one lock file...

wonder if pnpm 9 fixes it (probably a long shot though)

@mkszepp
Copy link
Collaborator Author

mkszepp commented Nov 12, 2024

Its a problem inside mono repo with pnpm and one lock file...

wonder if pnpm 9 fixes it (probably a long shot though)

no i don't think so... its still a open PR (since years 😅) i think NVP has a other setup published for github pipelines... but not sure which changes we need for them

@mkszepp
Copy link
Collaborator Author

mkszepp commented Nov 12, 2024

@Techn1x released in v8.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants