fix: compile with exactOptionalPropertyTypes and noImplicitOverride #687
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TypeScript consumers of this addon that build with the TS options
exactOptionalPropertyTypes
ornoImplicitOverride
currently fail to compile.This PR fixes the issue by explicitly marking overridden functions as
override
and adding an explicit| undefined
for optional interface & class members that can be assigned as undefined.