Cache forecast with ttl #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 1, 2024 17:01
Why? Each request to yr.no comes with an expiry time. We should not ask for the same forecast again if the first one is not expired. How? Extend the cache package to use PutWithTTL to the database. This will save an object. When we ask to retrieve that object, if it is expired it will throw a KeyExpired error. In order to allow this to happen, we need to change the cache implementation to pass through the errors which are returned from bitcask. Currently all of the logic is inside the command function. Ideally, this could be split out into a package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
Each request to yr.no comes with an expiry time. We should not ask for
the same forecast again if the first one is not expired.
How?
Extend the cache package to use PutWithTTL to the database. This will
save an object. When we ask to retrieve that object, if it is expired
it will throw a KeyExpired error. We should then call the yr.no api
In order to allow this to happen, we need to change the cache
implementation to pass through the errors which are returned from
bitcask.