Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Snapshot has already been released. #66

Closed
ci7lus opened this issue Jun 15, 2022 · 10 comments
Closed

Snapshot has already been released. #66

ci7lus opened this issue Jun 15, 2022 · 10 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@ci7lus
Copy link
Owner

ci7lus commented Jun 15, 2022

image

recoil-syncのバグ？
@ci7lus ci7lus added bug Something isn't working help wanted Extra attention is needed labels Jun 15, 2022
@ci7lus
Copy link
Owner Author

ci7lus commented Jun 16, 2022 •
edited
Loading

どうやらthrowされるのは開発環境だけなので、こちらの実装に問題なければupstreamが修正されずともrc抜けて良さそう

https://github.com/facebookexperimental/Recoil/blob/8852c1a422ccb1dcca9653b55f0e8b454a4216ea/packages/recoil/core/Recoil_Snapshot.js#L118

@ci7lus
Copy link
Owner Author

ci7lus commented Jun 21, 2022

アップデートしたら逆に頻発するようになって困った 起票してこようかな

@ci7lus
Copy link
Owner Author

ci7lus commented Jun 23, 2022

同じ階層にRecoilSyncが2つ並んでると起こる気がする…と思ったけど普通に発動してしまった、なんなんだ

@ci7lus
Copy link
Owner Author

ci7lus commented Jun 28, 2022 •
edited
Loading

facebookexperimental/Recoil#1891 再現できなかったのもののエスパーしていただき修正が入った、react-fast-refreshとの相性？

@ci7lus
Copy link
Owner Author

ci7lus commented Jul 9, 2022 •
edited
Loading

上記でも治らない、再現ができず全く見当がつかない
RecoilBridge?

ci7lus added a commit that referenced this issue Aug 13, 2022
@ci7lus
⬆️ recoilを更新 (#66)
d1de496
ci7lus added a commit that referenced this issue Aug 13, 2022
@ci7lus
⬆️ recoilを更新 (#66)
b983034
@ci7lus
Copy link
Owner Author

ci7lus commented Aug 13, 2022

facebookexperimental/Recoil#1936 で治ったらしいがまだ起きる気がする？様子見

ci7lus added a commit that referenced this issue Aug 13, 2022
@ci7lus
Merge pull request #83 from ci7lus/chore/upgrade-recoil-075
996acdf 
⬆️ recoilを更新 (#66)
@ci7lus
Copy link
Owner Author

ci7lus commented Aug 15, 2022

image

治っていない…気がします！

@ci7lus
Copy link
Owner Author

ci7lus commented Aug 15, 2022

devtoolを出すと死亡率が高い devtoolを開いている間のsetTimeoutに挙動差があるとか？

@ci7lus
Copy link
Owner Author

ci7lus commented Aug 15, 2022

出さなくても死んだ ホンマに何

@ci7lus
Copy link
Owner Author

ci7lus commented Oct 29, 2023

Facebook が出しているので Recoil は大丈夫です！

@ci7lus ci7lus closed this as completed Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ci7lus