Add delete home end support #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 23, 2015 13:16
|
@michalpristas Thanks for catching that. |
|
i think it is a great point. i will get back to it tomorrow morning |
|
I moved check as proposed, in order to do that had to pass the reader down to the method. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for Delete key and Home/End keys
Tested on Ubuntu
Delete key is weird as it is specified by set of 4 runes (instead of 3 as with Home, End, or Ctrl + Anything combo). The seqence is 27 91 51 126
So workaround was made (in terminal.go) for this case, it checks whether Delete command was used (Ctrl + D or Delete key both returns CharDelete) and if so then it checks if next rune in buf is 126 if not it will put it back on top of the stack.