Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(action-impl): sql action can read blob type #220

Merged
merged 5 commits into from
Nov 25, 2024
Merged

Conversation

rbenyoussef
Copy link
Contributor

Issue Number

fixes #

Describe the changes you've made

Describe if there is any unusual behaviour of your code

Additional context

Test plan

Checklist

  • Refer to issue(s) the PR solves
  • New java code is covered by tests
  • Add screenshots or gifs of the new behavior, if applicable.
  • All new and existing tests pass
  • No git conflict

@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 73.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 61.25%. Comparing base (d3db2ec) to head (7596ec1).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
.../com/chutneytesting/action/sql/core/SqlClient.java 73.33% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #220      +/-   ##
============================================
+ Coverage     60.94%   61.25%   +0.30%     
- Complexity     3361     3416      +55     
============================================
  Files           662      668       +6     
  Lines         18266    18492     +226     
  Branches       1005     1012       +7     
============================================
+ Hits          11133    11328     +195     
- Misses         6729     6757      +28     
- Partials        404      407       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

DelaunayAlex
DelaunayAlex previously approved these changes Nov 18, 2024
Copy link
Member

@boddissattva boddissattva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After checkout, got errors due to crlf line endings on sql files.
Everyting is ok after modifying pr files to lf line ending.
My local git config does not touch anything normally. I'll double check tomorrow.

@nbrouand
Copy link
Member

Oracle docker image is very big (1Go+). Could you check if it's possible to add docker image in a cache for github actions ?

nbrouand
nbrouand previously approved these changes Nov 25, 2024
@KarimGl KarimGl merged commit a125ae5 into main Nov 25, 2024
3 checks passed
@KarimGl KarimGl deleted the feat/sql_action branch November 25, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants