-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(action-impl): sql action can read blob type #220
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #220 +/- ##
============================================
+ Coverage 60.94% 61.25% +0.30%
- Complexity 3361 3416 +55
============================================
Files 662 668 +6
Lines 18266 18492 +226
Branches 1005 1012 +7
============================================
+ Hits 11133 11328 +195
- Misses 6729 6757 +28
- Partials 404 407 +3 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
chutney/action-impl/src/main/java/com/chutneytesting/action/sql/core/SqlClient.java
Show resolved
Hide resolved
chutney/action-impl/src/main/java/com/chutneytesting/action/sql/core/SqlClient.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After checkout, got errors due to crlf line endings on sql files.
Everyting is ok after modifying pr files to lf line ending.
My local git config does not touch anything normally. I'll double check tomorrow.
Oracle docker image is very big (1Go+). Could you check if it's possible to add docker image in a cache for github actions ? |
Issue Number
fixes #
Describe the changes you've made
Describe if there is any unusual behaviour of your code
Additional context
Test plan
Checklist